Add section on JSON Processing. #1202

msporny · 2023-07-14T22:15:51Z

This PR attempts to address issue #1201 by documenting how systems process the VCDM using pure JSON processing today.

index.html

mprorock · 2023-07-15T17:42:54Z

Isn't this more of just a JSON-LD issue than a VC issue? I am not sure I see the value of this PR as it is just saying that JSON-LD is JSON

mtaimela · 2023-07-16T16:23:44Z

Thank you @msporny for the clarification PR, I'm in favour of including this PR as is.

@mprorock wrote:

Isn't this more of just a JSON-LD issue than a VC issue? I am not sure I see the value of this PR as it is just saying that JSON-LD is JSON

I would say that it is beneficial for the community that is less technical than average contributor. The clarification is very clearly specifying the duality and the differences of json-ld/json in context of VC/VP, while promoting the use of @context. This "promoted" use of the mandatory @context is against pure json mindset, thus this added section is beneficial for the community.

index.html

decentralgabe

preemptively approving given a small number of tweaks. great addition!

index.html

Sakurann

This PR creates more confusion than clarification. One is confusion between payload and securing mechanism processing. Even for the the payload processing, since the base data model is +ld+json, JSON-LD is needed and for example it's misleading to talk about only +json.

Sakurann · 2023-07-19T12:09:34Z

index.html

+            <li>
+When using the JOSE or COSE specifications to secure a
+<a>verifiable credential</a> or <a>verifiable presentation</a>.
+            </li>


Suggested change

<li>

When using the JOSE or COSE specifications to secure a

<a>verifiable credential</a> or <a>verifiable presentation</a>.

</li>

This is a confusion between payload and securing mechanism processing. this should talk only about the payload which is JSON-LD.

I have accepted @mprorock's suggestions, does that work for you, @Sakurann? If not, please suggest some concrete language.

awoie · 2023-08-04T11:34:00Z

I filed #1227 to track documenting the value of "processing the core data model as JSON-LD" per the call yesterday.

My change requests on this PR are limited to accepting or dismissing the open suggestions, and once those are resolved, I intend to approve... We should start the related discussions on the value of processing the core data model as JSON-LD on the issue above, and not continue them on this PR... as its getting very difficult to review.

I will no longer block this PR if this is well documented in #1227. If we don't do that, the JSON section just leads to developer confusion.

awoie

I still doubt the usefulness of this section but I'm not blocking it either.

index.html

OR13 · 2023-08-04T21:43:24Z

Noting conflicts exist, there are new change suggestions, and despite @awoie 's comment here: #1202 (comment)

He is still marked as blocking the PR... as is @Sakurann .

brentzundel · 2023-08-07T21:49:30Z

@awoie since you have indicated you are no longer blocking, I have dismissed your review.

@Sakurann there have been many changes since your request, please re-review.

He has indicated that he no longer wishes to block this PR #1202 (review)

brentzundel

I agree with others that this information will be much better once accompanied by the changes discussed in issue #1227

Sakurann

Appreciate the work that has gone into this PR. Not blocking. Looking forward to a similar section on JSON-LD processing.

iherman · 2023-08-09T16:12:42Z

The issue was discussed in a meeting on 2023-08-09

no resolutions were taken

View the transcript

2.3. Add section on JSON Processing. (pr vc-data-model#1202)

See github pull request vc-data-model#1202.

Manu Sporny: PR 1202, everyone who needs to reviewed has reviewed, need JSON/JSON-LD processing section, conflicts needs to be resolved, plan to merge tomorrow.

Co-authored-by: Dave Longley <[email protected]>

Co-authored-by: Mike Prorock <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>

Co-authored-by: Mike Prorock <[email protected]>

Co-authored-by: Orie Steele <[email protected]>

Co-authored-by: Dave Longley <[email protected]>

…ing. Co-authored-by: Dave Longley <[email protected]>

Co-authored-by: Ted Thibodeau Jr <[email protected]>

msporny · 2023-08-09T22:19:53Z

Editorial, substantive, multiple reviews, changes requested and made, no remaining objections, merging.

msporny requested review from OR13, selfissued, decentralgabe and awoie as code owners July 14, 2023 22:15

msporny requested review from davidlehn, dlongley, iherman, dmitrizagidulin, TallTed, brentzundel and Sakurann July 14, 2023 22:16

msporny mentioned this pull request Jul 14, 2023

Document how VCs are processed as JSON today #1201

Closed

dlongley approved these changes Jul 15, 2023

View reviewed changes

dlongley reviewed Jul 15, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

iherman reviewed Jul 15, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

msporny mentioned this pull request Jul 15, 2023

Remove JSON section in lieu of application/vc+ld+json. #1088

Merged

mprorock requested changes Jul 17, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

decentralgabe reviewed Jul 17, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

decentralgabe approved these changes Jul 17, 2023

View reviewed changes

TallTed reviewed Jul 18, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Sakurann suggested changes Jul 19, 2023

View reviewed changes

Sakurann reviewed Jul 19, 2023

View reviewed changes

iherman mentioned this pull request Jul 20, 2023

Conformance requirements for normative context #1185

Closed

msporny force-pushed the msporny-json-processing branch from b136572 to 91cb4e6 Compare July 23, 2023 14:00

iherman self-requested a review July 23, 2023 14:03

iherman approved these changes Jul 23, 2023

View reviewed changes

msporny requested review from mprorock and Sakurann July 23, 2023 14:14

awoie reviewed Aug 4, 2023

View reviewed changes

awoie self-requested a review August 4, 2023 12:52

TallTed requested changes Aug 4, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

msporny requested a review from TallTed August 4, 2023 22:11

TallTed approved these changes Aug 4, 2023

View reviewed changes

brentzundel approved these changes Aug 7, 2023

View reviewed changes

Sakurann approved these changes Aug 9, 2023

View reviewed changes

msporny and others added 14 commits August 9, 2023 18:14

Add section on JSON Processing.

9d5f50f

Simplify JSON Processing statement about context content.

459bb0e

Co-authored-by: Dave Longley <[email protected]>

Further clarifications on JSON-only processing.

2f58fc1

Co-authored-by: Mike Prorock <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>

Mark JSON Processing section as non-normative.

63fe870

Add reference to Data Schemas from JSON Processing section.

f031ab2

Generalize statement about "databases" in JSON Processing.

6827cdb

Co-authored-by: Mike Prorock <[email protected]>

Reword intro to JSON Processing text provided by @mprorock.

369c752

Clarify multiple base media types in JSON Processing section.

08966f8

Co-authored-by: Orie Steele <[email protected]>

Clarify no need to do JSON-LD Processing when using external proofs.

da459b0

Co-authored-by: Orie Steele <[email protected]>

Remove "pure" language from JSON Processing section.

3ff4c08

Fix JSON-LD transformations language in JSON Processing.

eb304b8

Co-authored-by: Dave Longley <[email protected]>

Elaborate on "know to be valid" language in JSON Processing.

8060490

Clarify "before securing or after verifying" language in JSON Process…

64e2604

…ing. Co-authored-by: Dave Longley <[email protected]>

Fix syntax/grammar in JSON Processing.

f007a19

Co-authored-by: Ted Thibodeau Jr <[email protected]>

msporny force-pushed the msporny-json-processing branch from e0b7b84 to f007a19 Compare August 9, 2023 22:18

msporny merged commit 59a9ca0 into main Aug 9, 2023

msporny deleted the msporny-json-processing branch August 9, 2023 22:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add section on JSON Processing. #1202

Add section on JSON Processing. #1202

msporny commented Jul 14, 2023 •

edited by pr-preview bot

Loading

mprorock commented Jul 15, 2023

mtaimela commented Jul 16, 2023

decentralgabe left a comment

Sakurann left a comment

Sakurann Jul 19, 2023

msporny Jul 23, 2023 •

edited

Loading

awoie commented Aug 4, 2023

awoie left a comment

OR13 commented Aug 4, 2023

brentzundel commented Aug 7, 2023

brentzundel left a comment

Sakurann left a comment

iherman commented Aug 9, 2023

2.3. Add section on JSON Processing. (pr vc-data-model#1202)

msporny commented Aug 9, 2023

Add section on JSON Processing. #1202

Add section on JSON Processing. #1202

Conversation

msporny commented Jul 14, 2023 • edited by pr-preview bot Loading

mprorock commented Jul 15, 2023

mtaimela commented Jul 16, 2023

decentralgabe left a comment

Choose a reason for hiding this comment

Sakurann left a comment

Choose a reason for hiding this comment

Sakurann Jul 19, 2023

Choose a reason for hiding this comment

msporny Jul 23, 2023 • edited Loading

Choose a reason for hiding this comment

awoie commented Aug 4, 2023

awoie left a comment

Choose a reason for hiding this comment

OR13 commented Aug 4, 2023

brentzundel commented Aug 7, 2023

brentzundel left a comment

Choose a reason for hiding this comment

Sakurann left a comment

Choose a reason for hiding this comment

iherman commented Aug 9, 2023

2.3. Add section on JSON Processing. (pr vc-data-model#1202)

msporny commented Aug 9, 2023

msporny commented Jul 14, 2023 •

edited by pr-preview bot

Loading

msporny Jul 23, 2023 •

edited

Loading